[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

[Nathan James via Phabricator via cfe-commits]

njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/misc/UnusedUsingDeclsCheck.cpp:186
-      // Emit a fix and a fix description of the check;
-      diag(Context.FoundUsingDecl->getLocation(),
-           /*Description=*/"remove the using", DiagnosticIDs::Note)
----------------
aaron.ballman wrote:
> Should this change be a separate patch?
It's either modify the check to put the fix in the warning, or modify the test so that fix notes is specified. 


================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:500
+  // --fix-errors and --fix-notes imply --fix.
+  FixBehaviour Behaviour = FixNotes             ? FB_FixNotes
+                           : (Fix || FixErrors) ? FB_Fix
----------------
aaron.ballman wrote:
> Might as well fix this clang-format warning.
I think this is a discrepancy with the clang format in using (truck) and the pre merge. Mine isn't complaining about format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84924/new/

https://reviews.llvm.org/D84924