[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 26 19:29:16 PST 2021
MaskRay added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:477
+ StringRef Message = D.getMessage();
+ if (Message.startswith("error: "))
+ Message = Message.substr(7);
----------------
`StringRef::consume_front`
I know you are moving code, but do you know why it needs to chop off the `error: ` prefix (why does the message get a prefix here?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97449/new/
https://reviews.llvm.org/D97449
More information about the cfe-commits
mailing list