[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers
Dmitry Polukhin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 26 10:18:17 PST 2021
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
@njames93 thank you for quick response and good suggestion!
================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4
+// RUN: FileCheck -input-file=%T/modernize-concat-nested-namespaces.h %S/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h -check-prefix=CHECK-FIXES
+// Restore header file and re-run with c++2b:
+// RUN: cp %S/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h %T/modernize-concat-nested-namespaces.h
----------------
njames93 wrote:
> Why do we explicitly run on c++2b and not c++20? I understand there is no framework in place for using -std=c++17-or-later when header files are modified.
There is no good reason, I just took highest current version. Changed to c++20.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97563/new/
https://reviews.llvm.org/D97563
More information about the cfe-commits
mailing list