[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

Tommy Chiang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 26 08:45:50 PST 2021


oToToT added inline comments.


================
Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:368
   // Create the target instance.
-  Clang->setTarget(TargetInfo::CreateTargetInfo(
-      Clang->getDiagnostics(), Clang->getInvocation().TargetOpts));
-  if (!Clang->hasTarget())
+  if (!Clang->createTarget())
     return BuildPreambleError::CouldntCreateTargetInfo;
----------------
Changing this without other further patch might cause `clangd` results in Runtime Error while handling files like CUDA.
Should I also include the patch of `clangd` or other related projects into this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97561/new/

https://reviews.llvm.org/D97561



More information about the cfe-commits mailing list