[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.
James Y Knight via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 26 08:08:45 PST 2021
jyknight added inline comments.
================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1037
+ assert(AddrAlign >= ResultTy->getPrimitiveSizeInBits() / 8 &&
+ "Expected at least natural alignment at this point.");
----------------
jrtc27 wrote:
> Doesn't this introduce another copy of the same problem that D91256 is fixing (even if that one happens to also be fixed by this patch)?
It sure does, although in a different function. :) Fixed in 740e69b6fdc2b1415065f3d20acc4d10a73edb00, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97223/new/
https://reviews.llvm.org/D97223
More information about the cfe-commits
mailing list