[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84
+llvm::cl::opt<size_t> IdleTimeoutSeconds(
+    "idle-timeout", llvm::cl::init(10),
+    llvm::cl::desc("Maximum time a channel may stay idle until server closes "
----------------
sammccall wrote:
> kadircet wrote:
> > sammccall wrote:
> > > 10 seems much too low, maybe set this to 5 min or so?
> > > Going idle for a minute or so seems common, and the only real reason we have to time connections out is to beat the gcp firewall. So I don't see the need to be really aggressive here.
> > oops this was meant to be 10 minutes, not seconds :D
> Haha, makes more sense :-)
> 
> Setting this to exactly the gcp timeout seems tempting fate with hard to debug races. Maybe 8 min?
fair point, done!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97536/new/

https://reviews.llvm.org/D97536