[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 26 01:26:35 PST 2021


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84
+llvm::cl::opt<size_t> IdleTimeoutSeconds(
+    "idle-timeout", llvm::cl::init(10),
+    llvm::cl::desc("Maximum time a channel may stay idle until server closes "
----------------
10 seems much too low, maybe set this to 5 min or so?
Going idle for a minute or so seems common, and the only real reason we have to time connections out is to beat the gcp firewall. So I don't see the need to be really aggressive here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97536/new/

https://reviews.llvm.org/D97536



More information about the cfe-commits mailing list