[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

Quentin Chateau via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 25 10:04:53 PST 2021


qchateau added a comment.

The hardcoded 5 premables can indeed be changed, I did not want to waste time on coding a configuration logic at such an early stage.

Well indeed do some extra work if we elect a compatible but almost useless preamble. We'll basically do the work twice (but at least we do it concurrently \o/). I can look into adding a heuristic layer to detect almost useless preambles and reject them. Though I'm not sure how I could do this as a single header can contain 99% of the preamble through include chains

Anyway that's the current state of this patch: it's already pretty cool (it does speed things up noticeably) but there are probably tons of flaws or potential improvements and I'd like to receive comments from another POV


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97417/new/

https://reviews.llvm.org/D97417



More information about the cfe-commits mailing list