[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

Thu Feb 25 09:24:09 PST 2021

MaskRay added a comment.

In D97446#2587806 <https://reviews.llvm.org/D97446#2587806>, @probinson wrote:

>> GNU ld has a rule "start_/stop_ references from a live input section retain the associated C identifier name sections",
>
> which LLD may change in the future (D96914 <https://reviews.llvm.org/D96914>).
>
> The phrasing "may change" implies LLD could eliminate the rule; in fact D96914 <https://reviews.llvm.org/D96914> will only add a way to opt-out of the rule.  You can't eliminate the rule entirely without breaking a lot of useful cases.

Reworded this sentence. D96914 <https://reviews.llvm.org/D96914> does add a way to opt-out of the rule. In the future (when toolchains are more mature) we may try. My internal tests and Linux kernel tests are try to state that we may not have many dependent cases.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97446/new/

https://reviews.llvm.org/D97446