[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld

Albion Fung via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 25 00:29:37 PST 2021


Conanap added inline comments.


================
Comment at: clang/test/Driver/hip-sanitize-options.hip:29
 // CHECK-NOT: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address"}}
-// CHECK-NOT: {{"[^"]*lld[^"]*".* ".*hip.bc"}}
+// CHECK-NOT: {{"[^"]*lld".* ".*hip.bc"}}
 // CHECK: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}}
----------------
yaxunl wrote:
> yaxunl wrote:
> > this may fail on windows since lld becomes lld.exe
> may be change to
> 
> 
> ```
> {{"[^"]*lld[^"]*".* "-plugin-opt=.* ".*hip.bc"}}
> ```
> 
> similar as below
Should be fixed now


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97423/new/

https://reviews.llvm.org/D97423



More information about the cfe-commits mailing list