[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld
Albion Fung via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 24 15:59:45 PST 2021
Conanap created this revision.
Conanap added reviewers: yaxunl, PowerPC, nemanjai, saghir.
Conanap added projects: LLVM, clang, PowerPC, AMDGPU.
Herald added a subscriber: steven.zhang.
Conanap requested review of this revision.
This test case was causing a PowerPC buildbot to fail as it happened to be named `lld-multistage`, which matches with the original regex and therefore fails the check-not. This should better represent the desired check.
Original differential: https://reviews.llvm.org/D96835
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D97423
Files:
clang/test/Driver/hip-sanitize-options.hip
Index: clang/test/Driver/hip-sanitize-options.hip
===================================================================
--- clang/test/Driver/hip-sanitize-options.hip
+++ clang/test/Driver/hip-sanitize-options.hip
@@ -26,15 +26,15 @@
// RUN: %s 2>&1 | FileCheck -check-prefixes=FAIL %s
// CHECK-NOT: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address"}}
-// CHECK-NOT: {{"[^"]*lld[^"]*".* ".*hip.bc"}}
+// CHECK-NOT: {{"[^"]*lld".* ".*hip.bc"}}
// CHECK: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}}
// NORDC: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address".*}} "-o" "[[OUT:[^"]*.bc]]"
-// NORDC: {{"[^"]*lld[^"]*".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}}
+// NORDC: {{"[^"]*lld".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}}
// NORDC: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}}
// RDC: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}}
// RDC: {{"[^"]*clang[^"]*".* "-emit-llvm-bc".* "-fcuda-is-device".* "-fsanitize=address".*}} "-o" "[[OUT:[^"]*.bc]]"
-// RDC: {{"[^"]*lld[^"]*".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}}
+// RDC: {{"[^"]*lld".*}} "[[OUT]]" {{".*asanrtl.bc" ".*hip.bc"}}
// FAIL: AMDGPU address sanitizer runtime library (asanrtl) is not found. Please install ROCm device library which supports address sanitizer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97423.326227.patch
Type: text/x-patch
Size: 1393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210224/c7051446/attachment-0001.bin>
More information about the cfe-commits
mailing list