[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 24 14:01:51 PST 2021


aganea added inline comments.


================
Comment at: clang/tools/driver/driver.cpp:349
                         "source, and associated run script.\n");
-  SmallVector<const char *, 256> argv(argv_, argv_ + argc_);
+  SmallVector<const char *, 256> ArgValues(Argv, Argv + Argc);
 
----------------
What about just `Args`? "Values" sounds a bit too broad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97138/new/

https://reviews.llvm.org/D97138



More information about the cfe-commits mailing list