[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

[Marco Antognini via Phabricator via cfe-commits]

mantognini added a comment.

Some minor comments.



================
Comment at: clang/docs/OpenCLSupport.rst:197
+parsing it should not require clang source code modifications. Most commonly
+such extensions add functionality via libraries (by adding new non-native
+types or functions) parsed regularly. Similar to other languages this is the
----------------



================
Comment at: clang/docs/OpenCLSupport.rst:219
+
+Pragmas without detailed information of its behavior (explanation of changes it
+triggers in the parsing) should not be added to clang. Moreover, the acceptable
----------------
svenvh wrote:
> 
"of //their// behavior", I think.


================
Comment at: clang/docs/OpenCLSupport.rst:223
+
+Note that some legacy extensions (published prior to OpenCL 3.0), however still
+provide some non-conformant functionality for pragmas e.g. add diagnostics on
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97072/new/

https://reviews.llvm.org/D97072