[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

Abhina Sree via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 24 07:03:46 PST 2021


abhina.sreeskantharajan added a comment.

@ASDenysPetrov are you running python inside MSYS bash that is installed by

> pacman -S --needed base-devel mingw-w64-x86_64-toolchain

? I learned that the python should give different output

  >>> sys.platform
  msys
  >>> platform.system()
  MSYS_NT-10.0-19041
  >>> sysconfig.get_platform()
  msys-3.1.7-x86_64

After taking a look at the CMakeCache.txt, I think a potential workaround would be to check if config.host_cxx contains MSYS2 which is set to CMAKE_CXX_COMPILER:FILEPATH=D:/WORK/Utilities/MSYS2/mingw64/bin/c++.exe if we can't determine MSYS through python.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95246/new/

https://reviews.llvm.org/D95246



More information about the cfe-commits mailing list