[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

[Deep Majumder via Phabricator via cfe-commits]

RedDocMD marked 2 inline comments as done.
RedDocMD added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:466-467
+      return;
+    OS << "Obtained null inner pointer from";
+    checkAndPrettyPrintRegion(OS, ThisRegion);
+  }));
----------------
steakhal wrote:
> RedDocMD wrote:
> > steakhal wrote:
> > > You should emit a //sort of grammatically correct// diagnostic message even if the region can not be pretty-printed.
> > > You should emit a //sort of grammatically correct// diagnostic message even if the region can not be pretty-printed.
> > 
> > @steakhal Does it look better now?
> Can we cover both branches with tests?
I am not sure if this can be done. Because, right now the only Smart Pointer that has been handled is `std::unique_ptr`.  It turns out that it can be pretty printed already, so I don't know how to test the other branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97183/new/

https://reviews.llvm.org/D97183