[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

Brent Royal-Gordon via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 23 13:58:30 PST 2021


brentdax accepted this revision.
brentdax added a comment.
This revision is now accepted and ready to land.

Looks good. Thanks for implementing this!



================
Comment at: clang/lib/Lex/LiteralSupport.cpp:1647
       ThisTokEnd -= ThisTokBuf - Prefix;
       assert(ThisTokEnd >= ThisTokBuf && "malformed raw string literal");
 
----------------
In your shoes, I would also have promoted this to a real check, but if you think that's overkill I'm fine with leaving it as it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94950/new/

https://reviews.llvm.org/D94950



More information about the cfe-commits mailing list