[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 22 08:07:27 PST 2021


njames93 marked an inline comment as done.
njames93 added inline comments.


================
Comment at: clang/test/FixIt/fixit-static-assert.cpp:2-3
+// RUN: %clang_cc1 -std=c++14 %s -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s
+// Ensure no warnings are emitted in c++17.
+// RUN: %clang_cc1 -std=c++17 %s -Werror -fsyntax-only
+// RUN: %clang_cc1 -std=c++14 %s -fixit-recompile -fixit-to-temporary -Werror
----------------
aaron.ballman wrote:
> Any reason not to pass `-verify=cxx17` and `// cxx17-no-diagnostics`?
I don't know my way around clang testing framework that well.
For the recompile test I think Werror has to be used as verify resulted in an assertion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89065/new/

https://reviews.llvm.org/D89065



More information about the cfe-commits mailing list