[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

Shilei Tian via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 22 06:37:33 PST 2021


tianshilei1992 added a comment.

In D96877#2578756 <https://reviews.llvm.org/D96877#2578756>, @ye-luo wrote:

> In D96877#2578752 <https://reviews.llvm.org/D96877#2578752>, @tianshilei1992 wrote:
>
>> In D96877#2578748 <https://reviews.llvm.org/D96877#2578748>, @ye-luo wrote:
>>
>>> to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc as a solution for forward compatibility until a clean solution lands.
>>
>> We’ll have newer version LLVM like 12.1 or 12.01 w/ a *right* solution. I don’t think we need to think that further.
>
> This doesn't help people who needs to run exactly 12.0. Also cannot wait for a minor release, need things to work right away when a new cuda toolkit is installed intentionally.

First, we don’t know whether a new version of CUDA will be released during this time, especially considering the release history of CUDA, 11.3 is not that possible, and 12 will not come out so soon. Second, even if NVIDIA’s people are so brilliant and release CUDA 12 in a short time,  we have a mechanism for user to work around the issue using the option `libomptarget-nvptx-bc-path`. This patch is just a work around, and it contains so many uncertainties, which cannot be called “forward compatibility” at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96877/new/

https://reviews.llvm.org/D96877



More information about the cfe-commits mailing list