[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

[Dmitry Polukhin via Phabricator via cfe-commits]

DmitryPolukhin added a comment.

@shixiao do you have plans to keep working on this diff? If not, do you have any objections if I send for review a similar diff that will eliminate the check `Sources.isInMainFile` and will rely on generic header filtration mechanism in clang-tidy?

We have faced the same issue on our codebase and would like to make this check works on headers too.

In D61989#2367012 <https://reviews.llvm.org/D61989#2367012>, @njames93 wrote:

> Tbh clang-tidy already handles disabling warnings for header files, so some of the code here isn't needed

+1 to use generic header filtration mechanism and avoid adding new option for this particular check. I tried to find the reason why `Sources.isInMainFile` was added but it looks like it was not even discussed during initial codereview D52136 <https://reviews.llvm.org/D52136>

Everyone please speak up if there is a good reason to limit this check to the main file only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61989/new/

https://reviews.llvm.org/D61989