[clang] bf15697 - [clang][cli] Stop creating '-Wno-stdlibcxx-not-found' in cc1

Jan Svoboda via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 22 00:53:50 PST 2021


Author: Jan Svoboda
Date: 2021-02-22T09:53:25+01:00
New Revision: bf15697e9b66b8f7e6f3f7c510a259651810bd29

URL: https://github.com/llvm/llvm-project/commit/bf15697e9b66b8f7e6f3f7c510a259651810bd29
DIFF: https://github.com/llvm/llvm-project/commit/bf15697e9b66b8f7e6f3f7c510a259651810bd29.diff

LOG: [clang][cli] Stop creating '-Wno-stdlibcxx-not-found' in cc1

This patch stops creating the '-Wno-stdlibcxx-not-found' argument in `CompilerInvocation::CreateFromArgs`.

The code was added in 2e7ab55e657f (a follow-up to D48297). However, D61963 removes relevant tests and starts explicitly passing '-Wno-stdlibcxx-not-found' to the driver. I think it's fair to assume this is a dead code.

Reviewed By: dexonsmith

Differential Revision: https://reviews.llvm.org/D97042

Added: 
    

Modified: 
    clang/lib/Frontend/CompilerInvocation.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp
index a49c97860324..45fb4f60a396 100644
--- a/clang/lib/Frontend/CompilerInvocation.cpp
+++ b/clang/lib/Frontend/CompilerInvocation.cpp
@@ -4588,12 +4588,6 @@ bool CompilerInvocation::CreateFromArgs(CompilerInvocation &Res,
                              Res.getPreprocessorOpts().Includes, Diags);
     if (Res.getFrontendOpts().ProgramAction == frontend::RewriteObjC)
       LangOpts.ObjCExceptions = 1;
-    if (T.isOSDarwin() && DashX.isPreprocessed()) {
-      // Supress the darwin-specific 'stdlibcxx-not-found' diagnostic for
-      // preprocessed input as we don't expect it to be used with -std=libc++
-      // anyway.
-      Res.getDiagnosticOpts().Warnings.push_back("no-stdlibcxx-not-found");
-    }
   }
 
   if (LangOpts.CUDA) {


        


More information about the cfe-commits mailing list