[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

Darwin Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 21 21:43:06 PST 2021


darwin added inline comments.


================
Comment at: clang/lib/Format/WhitespaceManager.cpp:716-717
             break;
           if (Next->isOneOf(TT_StartOfName, TT_FunctionDeclarationName,
                             tok::kw_operator))
             return false;
----------------
Maybe I should combine the conditions into this `isOneOf(...)` together since they all return false.

Well, when I was writing this, I remembered why I had put the check before line 714. It was because line 714 would be executed and breaks in that scenario.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97137/new/

https://reviews.llvm.org/D97137



More information about the cfe-commits mailing list