[PATCH] D97137: Bug fix of https://bugs.llvm.org/show_bug.cgi?id=49175

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 21 05:12:36 PST 2021


curdeius added a comment.

Seems pretty ok at a first glance. I'll have a deeper look this week.
Please update the revision title to something more comprehensible and move the bug link to the summary.



================
Comment at: clang/unittests/Format/FormatTest.cpp:14257
+
+  Alignment.PointerAlignment = FormatStyle::PAS_Left;
+  verifyFormat("unsigned int*       a;\n"
----------------
Could you please test as well mixed pointers and references?


================
Comment at: clang/unittests/Format/FormatTest.cpp:14260
+               "int*                b;\n"
+               "unsigned int Const* c;",
+               Alignment);
----------------
Could you please test `const` as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97137/new/

https://reviews.llvm.org/D97137



More information about the cfe-commits mailing list