[PATCH] D96838: Add GNU attribute 'retain'

[Petr Hosek via Phabricator via cfe-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/test/CodeGen/attr-retain.c:11
+/// Set !retain only on ELF platforms.
+// NORETAIN-NOT: !retain
+
----------------
There are no `FileCheck --check-prefixes=NORETAIN` invocations so this is unused.


================
Comment at: clang/test/CodeGen/attr-retain.c:21
+int g1 __attribute__((retain));
+__attribute__((retain)) static int g2;
+__attribute__((used,retain)) static int g3;
----------------
Would it be possible to also include negative check for `g2`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96838/new/

https://reviews.llvm.org/D96838