[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874
 /// [C++0x] static_assert-declaration:
 ///           static_assert ( constant-expression  ,  string-literal  ) ;
 ///
----------------
xbolva00 wrote:
> Do we warn for:
> 
> static_assert(“my msg”)? 
> 
> I remember some long time ago bug in llvm itself -  assert(“my msg”) - condition expr was missing.
We don't, but that would be a reasonable warning to add (not necessarily as part of this patch).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89065/new/

https://reviews.llvm.org/D89065