[PATCH] D96847: [clang][cli] Store additional optimization remarks info
    Duncan P. N. Exon Smith via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Fri Feb 19 22:26:14 PST 2021
    
    
  
dexonsmith added a comment.
In D96847#2574408 <https://reviews.llvm.org/D96847#2574408>, @jansvoboda11 wrote:
> That's a bit nicer.
>
> Not sure if `RemarkPattern` is a good name now, as it may represent an optimization remark that doesn't have any pattern associated with it.
> How about calling it `OptimizationRemark` and merging `operator bool` and `operator ->` into `bool patternMatch(...) { return Pattern && Pattern.match(...); }`?
Seems reasonable. Or `matchesPattern(...)`?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96847/new/
https://reviews.llvm.org/D96847
    
    
More information about the cfe-commits
mailing list