[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Fri Feb 19 10:31:42 PST 2021

azabaznov added inline comments.

================
Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71
+OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100)
+OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20)

----------------
I think core and optional core features do not require pragma too. So for example 3d image writes or fp64 do not require pragma in OpenCL C 2.0. Isn't that so?

================
Comment at: clang/test/SemaOpenCL/extension-version.cl:217
+
+// Check that pragmas for the OpenCL 3.0 features are rejected.
+
----------------
Again about core or optional core: don't you feel that current diagnostic is good already (https://godbolt.org/z/Kcjdvr)?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97052/new/

https://reviews.llvm.org/D97052