[PATCH] D96919: [clang] Emit type metadata on available_externally vtables for WPD

David Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 19 10:30:07 PST 2021


davidxl added inline comments.


================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1770
 
-  if (!VTable->isDeclarationForLinker())
+  if (!VTable->isDeclarationForLinker() ||
+      CGM.getCodeGenOpts().WholeProgramVTables) {
----------------
Can you add some comment here -- also help user understand the code. Note that isDeclarationForLinker is not intuitive by name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96919/new/

https://reviews.llvm.org/D96919



More information about the cfe-commits mailing list