[PATCH] D97053: [clang][SVE] Don't warn on vector to sizeless builtin implicit conversion

[Joe Ellis via Phabricator via cfe-commits]

joechrisellis added inline comments.


================
Comment at: clang/test/Sema/aarch64-fixed-vector-to-scalable-implicit-conversion.c:1-32
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve \
+// RUN: -msve-vector-bits=512 -Wconversion -fallow-half-arguments-and-returns \
+// RUN: -o /dev/null %s 2>&1 | FileCheck %s -allow-empty
+
+// CHECK-NOT: warning
+
+#include <arm_sve.h>
----------------
c-rhodes wrote:
> I wonder if we can just add `-Wconversion` to the existing Sema tests?
> * clang/test/Sema/attr-arm-sve-vector-bits.c
> * clang/test/SemaCXX/attr-arm-sve-vector-bits.cpp
> 
`clang/test/Sema/attr-arm-sve-vector-bits.c` contains a lot of `// expected-error ...` and such, so I'm reluctant to make changes to that because it seems a little weird to mix up expected errors and non-expected warnings.

I suppose we could cat this test into `attr-arm-sve-vector-bits.cpp`, though, if you would prefer? 🙂 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97053/new/

https://reviews.llvm.org/D97053