[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 19 05:37:11 PST 2021


jansvoboda11 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4267
 
+  if (Triple.isSPIR())
+    CmdArgs.push_back("-Wspir-compat");
----------------
Anastasia wrote:
> It seems like this should have been in `addClangWarningOptions` but there is no toolchain for SPIR?
> 
> Could we add a FIXME at least saying that this deviates from the default flow right now?
That's right. I added the FIXME.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97041/new/

https://reviews.llvm.org/D97041



More information about the cfe-commits mailing list