[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 19 05:23:27 PST 2021
Anastasia added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4267
+ if (Triple.isSPIR())
+ CmdArgs.push_back("-Wspir-compat");
----------------
It seems like this should have been in `addClangWarningOptions` but there is no toolchain for SPIR?
Could we add a FIXME at least saying that this deviates from the default flow right now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97041/new/
https://reviews.llvm.org/D97041
More information about the cfe-commits
mailing list