[PATCH] D97000: [clang] Increase the bitness of data length in ASTDeclContextNameLookup

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 18 17:22:25 PST 2021


rsmith added a comment.

Thanks for the diagnosis and the patch!

We spend a significant amount of our AST file size on these lookup tables, so I think the extra two bytes per lookup entry is best avoided if possible. We also have the same problem for other on-disk hash tables. I went ahead and generalized this to cover all of our on-disk hash tables and switched from fixed-width to variable-width encoding in rGe0589d70fb8e29842fab228df716f73b378710a6 <https://reviews.llvm.org/rGe0589d70fb8e29842fab228df716f73b378710a6>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97000/new/

https://reviews.llvm.org/D97000



More information about the cfe-commits mailing list