[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 18 12:30:38 PST 2021


thakis added a comment.

In D96816#2572431 <https://reviews.llvm.org/D96816#2572431>, @thakis wrote:

> See maybe also https://reviews.llvm.org/D73202 . Do we need to bump serialization::VERSION_MINOR ?

I gave that a try in http://reviews.llvm.org/rG063236646849564094f5fcfc947ad36dba0efedb . Looks like it did the trick: http://45.33.8.238/linux/39740/step_7.txt Some other test is also broken, but the breakage caused by this change is fixed in that build. So the failure happened with LLVM_APPEND_VC_REV=NO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96816/new/

https://reviews.llvm.org/D96816



More information about the cfe-commits mailing list