[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes
Andrzej Warzynski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 18 11:12:37 PST 2021
awarzynski added inline comments.
================
Comment at: flang/test/Flang-Driver/fdefault.f90:10
+! RUN: not %flang-new -fsyntax-only -fdefault-double-8 %s 2>&1 | FileCheck %s --check-prefix=DOUBLE
+! RUN: mkdir -p %t/dir-flang-new && %flang-new -fsyntax-only -module-dir %t/dir-flang-new -fdefault-real-8 %s 2>&1
+! RUN: cat %t/dir-flang-new/m.mod | grep 'real_kind=8_4'
----------------
tskeith wrote:
> I don't think you need to create a subdirectory. `%t` is a temp directory specific to this test.
>
> So I'm suggesting:
> ```
> ! RUN: %flang -fsyntax-only -fdefault-real-8 %s
> ```
>From [[ https://llvm.org/docs/CommandGuide/lit.html#substitutions | LIT docs ]]:
```
%t temporary file name unique to the test
%T parent directory of %t (not unique, deprecated, do not use)
```
So, IIUC, we do need to create a directory. We could skip `<dir-flang-new>` in the directory name, but it does no harm and can be really helpful when parsing CI logs.
I might be missing something though. @tskeith ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96344/new/
https://reviews.llvm.org/D96344
More information about the cfe-commits
mailing list