[PATCH] D95017: [clang-format] Add case aware include sorting.

Chris Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 18 10:01:12 PST 2021


PragmaNull added a comment.

I find the naming of the case sensitive options confusing here. 
When I read "CaseSensitive" I think of the behavior of strcmp() which sorts according to "ASCIIbetical" order. But here "CaseSensitive" throws away case by comparing the result of "Filename.lower()" which I would consider case-insensitive, or the same behavior as a call to stricmp().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95017/new/

https://reviews.llvm.org/D95017



More information about the cfe-commits mailing list