[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 18 07:39:18 PST 2021


awarzynski added a comment.

Hi @Anastasia , thank you for working on this!

IIUC, this patch introduces:

- new input types: `TY_CLCXX` and `TY_CLCXXHeader`
- new language: `OpenCLCXX`

Based on the attached test, this is only to remove the need for `-cl-std=clc++`. Do you expect any other benefits of introducing the above ^^^? And are you planning to to update the OpenCL C++ tests not to use  `-cl-std=clc++`? Just trying to make sure I understand the reason behind this :)



================
Comment at: clang/lib/Driver/Types.cpp:163
 
-bool types::isOpenCL(ID Id) { return Id == TY_CL; }
+bool types::isOpenCL(ID Id) {
+  switch (Id) {
----------------
This is not used.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96771/new/

https://reviews.llvm.org/D96771



More information about the cfe-commits mailing list