[PATCH] D96784: Pass the cmdline aapcs bitfield options to cc1
Ties Stuij via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 18 03:46:29 PST 2021
stuij added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1525
+void AddAAPCSVolatileBitfieldArgs(const ArgList &Args, ArgStringList &CmdArgs) {
+ if (!Args.hasFlag(options::OPT_faapcs_bitfield_width,
----------------
DavidSpickett wrote:
> Name this AddARMAAPCSVolatileBitfieldArgs to match the other helpers.
I deliberately didn't add `ARM` to the name as this function is used by both the Arm and AArch64 targets, and `ARM` would cause confusion. I figured AAPCS is differentiating enough, as it implies Arm without choosing a specific arch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96784/new/
https://reviews.llvm.org/D96784
More information about the cfe-commits
mailing list