[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

[Arthur O'Dwyer via Phabricator via cfe-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/tuple:432
+void __memberwise_copy_assign(_Dest& __dest, _Source const& __source, __tuple_indices<_Np...>) {
+    __swallow(((_VSTD::get<_Np>(__dest) = _VSTD::get<_Np>(__source)), void(), int())...);
+}
----------------
Your friendly neighborhood ADL hater says: `_VSTD::__swallow` plz
(and line 438)
(and maybe `int()` is a sillier-than-necessary way to write `0`?)


================
Comment at: libcxx/include/tuple:891
+    {
+        __memberwise_copy_assign(*this, __tuple,
+            typename __make_tuple_indices<sizeof...(_Tp)>::type());
----------------
Your friendly neighborhood ADL hater says: `_VSTD::` plz
(and line 900)
(and line 931)
(and line 986)
(and line 1002)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50106/new/

https://reviews.llvm.org/D50106