[PATCH] D96886: [Driver] Clean up some Separate form options

[Fangrui Song via Phabricator via cfe-commits]

MaskRay created this revision.
MaskRay added reviewers: phosek, thakis.
Herald added subscribers: jansvoboda11, dang.
MaskRay requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Drop the `Separate` form of `-fmodule-name X`, `-fprofile-remapping-file X`, and `-frewrite-map-file X`.
To the best of my knowledge they are not used. Their conventional Joined forms (`-fFOO=`) should be used instead.

`-fdebug-compilation-dir X` is used in several places, e.g.  chromium/infra/goma.
It is also advertised in http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html
So we keep it but make the EQ form canonical and the Separate form an alias.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96886

Files:
  clang/include/clang/Driver/Options.td
  clang/lib/Driver/Driver.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Driver/ToolChains/CommonArgs.cpp
  clang/test/Driver/clang_f_opts.c
  clang/test/Driver/debug-comp-dir.S
  clang/test/Driver/debug.c
  clang/test/Driver/rewrite-map-files.c
  clang/test/Driver/rewrite-map-in-diagnostics.c
  clang/test/Driver/symbol-rewriter.c
  clang/test/Driver/working-directory.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96886.324365.patch
Type: text/x-patch
Size: 12348 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210217/23cd0217/attachment-0001.bin>