[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 17 10:37:03 PST 2021


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/Driver/debug-options-as.c:65
+// Check that -gdwarf-N can be placed before other options of the "-g" group.
+// RUN: %clang -### -c -g -gdwarf-3 -integrated-as -x assembler %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=DWARF3 %s
----------------
Nit: use the more common spelling `-fintegrated-as`

`-triple %itanium_abi_triple`

msvc windows triples ideally don't need `-dwarf-version=`, but that can be a separate clean-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96865/new/

https://reviews.llvm.org/D96865



More information about the cfe-commits mailing list