[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 16 15:10:35 PST 2021


dgoldman marked 2 inline comments as done.
dgoldman added inline comments.


================
Comment at: clang-tools-extra/clangd/AST.cpp:228
+    Out << (Method->isInstanceMethod() ? '-' : '+');
+    Method->getSelector().print(Out);
+    return Out.str();
----------------
sammccall wrote:
> in the other patch this was with `-[brackets]`
We don't want to put the full form (e.g. including the container name) here - that would repeat the class name in the document symbols when the methods are already nested under the class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96612/new/

https://reviews.llvm.org/D96612



More information about the cfe-commits mailing list