[PATCH] D96244: [clangd] Introduce Modules

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 16 13:39:30 PST 2021


sammccall added a comment.

In D96244#2566225 <https://reviews.llvm.org/D96244#2566225>, @dblaikie wrote:

> "modules" is a pretty overloaded term in Clang (between llvm Modules and Clang Modules and now C++ standard Modules) - any chance of some other term that might be less overloaded in this space?

You're right, and I'm not sure why we didn't bikeshed this name harder :-\
(FWIW Module is also a nod to Guice and its terrible DSLs for binding things things, which we borrow a bit here...)

ideas...
Component isn't terrible: I don't like it quite as much as i'm not sure it suggests the uniformity-of-interface as well.
Feature is what VSCode calls this on the client side. Personally I find this terribly confusing.
Plugin I don't think is great, because there's no dynamic loading or injection going on (clang plugins are well-named, but a different concept)
@kadircet any thoughts on these or more?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96244/new/

https://reviews.llvm.org/D96244



More information about the cfe-commits mailing list