[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Marco Antognini via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 16 08:15:54 PST 2021


mantognini added a comment.

I feel this would be a valuable addition, indeed. Only a minor question from me.



================
Comment at: clang/lib/Driver/Types.cpp:265
            .Case("cl", TY_CL)
+           .Case("clcpp", TY_CLCXX)
            .Case("cp", TY_CXX)
----------------
I'm not sure we want that -- I'm actually fine if we don't -- but I see below `c++` and `cxx` are supported in addition to `cpp`. Should we therefore also have `clc++` and `clcxx` as file valid extensions for consistency? I wonder what the general opinion is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96771/new/

https://reviews.llvm.org/D96771



More information about the cfe-commits mailing list