[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added inline comments.


================
Comment at: clang/docs/OpenCLSupport.rst:67
+All the options in this section are frontend-only and therefore if used
+with regular clang driver they require frontend forwarding e.g. ``-cc1``
+or ``-Xclang``.
----------------



================
Comment at: clang/docs/OpenCLSupport.rst:123
+Because the header is very large and long to parse, PCH (:doc:`PCHInternals`)
+and modules (:doc:`Modules`) are used internally to improve the compilation
+speed.
----------------
"are" or "can be"?


================
Comment at: clang/docs/UsersManual.rst:2942
+Allows to disable all extra types and functions that are not native to the compiler.
+This might reduce the compilation speed marginally but many declaration from the
+OpenCL standard won't be accessible i.e. the following example will fail to compile.
----------------



================
Comment at: clang/docs/UsersManual.rst:2943
+This might reduce the compilation speed marginally but many declaration from the
+OpenCL standard won't be accessible i.e. the following example will fail to compile.
 
----------------



================
Comment at: clang/docs/UsersManual.rst:2948
+     $ echo "bool is_wg_uniform(int i){return get_enqueued_local_size(i)==get_local_size(i);}" > test.cl
+     $ clang -cl-std=CL2.0 -cl-no-stdinc test.cl
 
----------------
Maybe include the error output from running this as well, because otherwise a hasty reader might assume this command should work?


================
Comment at: clang/docs/UsersManual.rst:3016
 
    .. code-block:: console
 
----------------
I wonder if we need to keep this example?  You're not referring to it from the text and it's not demonstrating any special flags anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96616/new/

https://reviews.llvm.org/D96616