[PATCH] D96690: [clangd] Treat paths case-insensitively depending on the platform

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 16 03:30:05 PST 2021


kadircet updated this revision to Diff 323951.
kadircet added a comment.
Herald added subscribers: ormris, mgorny.

- Don't case fold stored strings, or the ones passing interface boundaries
- Define a `pathIsAncestor` helper instead and use that for comparison of MountPoint
- Expose a CLANGD_PATH_CASE_INSENSITIVE macro, which is defined whenever the platform treats paths case-insensitively


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96690/new/

https://reviews.llvm.org/D96690

Files:
  clang-tools-extra/clangd/ConfigCompile.cpp
  clang-tools-extra/clangd/support/Path.cpp
  clang-tools-extra/clangd/support/Path.h
  clang-tools-extra/clangd/unittests/CMakeLists.txt
  clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp
  clang-tools-extra/clangd/unittests/RenameTests.cpp
  clang-tools-extra/clangd/unittests/support/PathTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96690.323951.patch
Type: text/x-patch
Size: 9235 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210216/93535e1b/attachment.bin>


More information about the cfe-commits mailing list