[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70
 
-The improvements are...
+- New :doc:`bugprone-thread-canceltype-asynchronous
+  <clang-tidy/checks/bugprone-thread-canceltype-asynchronous>` check.
----------------
Please add subsections for new checks and aliases. Looks like they were removed after release branch creation.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-thread-canceltype-asynchronous.rst:6
+
+  Finds ``pthread_setcanceltype`` function calls where a thread's cancellation
+  type is set to asynchronous (``PTHREAD_CANCEL_ASYNCHRONOUS``). Setting this
----------------
Please remove unnecessary indentation and synchronize first statement with Release Notes.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-thread-canceltype-asynchronous.rst:15
+
+    pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, &oldtype);
+
----------------
Please fix excessive indentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96719/new/

https://reviews.llvm.org/D96719