[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

Mon Feb 15 14:46:14 PST 2021

njames93 added a comment.

In D96142#2547418 <https://reviews.llvm.org/D96142#2547418>, @steveire wrote:

> In D96142#2545078 <https://reviews.llvm.org/D96142#2545078>, @njames93 wrote:
>
>> I'm not sure about this. The warning is good and addresses a real problem.
>
> Well, I've made the diagnostic better anyway.

I'm not sure its an improvement. If the template is never instantiated with something that would trigger this, we shouldn't really warn on it.
There are plenty of times when certain template definitions will error if certain template parameters are passed to them.
This is well defined and no compiler will ever warn on those situations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96142/new/

https://reviews.llvm.org/D96142