[PATCH] D96483: [flang][driver] Add options for unparsing

Mon Feb 15 08:02:22 PST 2021

awarzynski added a comment.

In D96483#2563323 <https://reviews.llvm.org/D96483#2563323>, @FarisRehman wrote:

> Do you know what the use of `GetActionKindName` in `FrontendOptions.h` is, as it is currently not being called anywhere and whilst this patch currently does not update that method with the 2 new cases, even if it did no change would be visible.

I'm not sure why this method is there TBH :) Perhaps @CarolineConcatto would know? I suspect that C&P error. I suggest removing it in a separate NFC patch. Thank you for pointing that out!

================
Comment at: flang/test/lit.cfg.py:82

+if config.include_flang_new_driver_test:
+   tools.append(ToolSubst('%flang_fc1', command=FindTool('flang-new'),
----------------
FarisRehman wrote:
> [nit] Is there a reason to have this as a separate `if-else` instead of merging with the existing `if-else`
Good point, updated!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96483/new/

https://reviews.llvm.org/D96483