[PATCH] D96483: [flang][driver] Add options for unparsing

Mon Feb 15 05:52:13 PST 2021

FarisRehman added a comment.

Thanks for working on this @awarzynski
Could you please clarify the situation regarding `GetActionKindName` in `FrontendOptions.h` as it is currently not being used anywhere and this patch currently does not update that method with the 2 new cases.
Other than that, looks good to me!

================
Comment at: flang/test/lit.cfg.py:82

+if config.include_flang_new_driver_test:
+   tools.append(ToolSubst('%flang_fc1', command=FindTool('flang-new'),
----------------
[nit] Is there a reason to have this as a separate `if-else` instead of merging with the existing `if-else`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96483/new/

https://reviews.llvm.org/D96483