[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

Sun Feb 14 12:19:05 PST 2021

aaronpuchert added a comment.

In D95754#2561849 <https://reviews.llvm.org/D95754#2561849>, @jlebar wrote:

> Not sure who can review this, but looking through blame it seems like maybe @aaronpuchert?

I'm by no means an expert on overloading, but this seems more like a usability question.

I like the idea. Let's give @rsmith a chance to chime in, otherwise I'll approve it after a while.

================
Comment at: clang/lib/Sema/Sema.cpp:2310

+  S.Diags.noteNumOverloadCandidatesShown(ShownOverloads);
+
----------------
Why not in the following `if`? I assume we want to show a long list not necessarily once, but only if it comes with the first error?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95754/new/

https://reviews.llvm.org/D95754