[PATCH] D96597: [DebugInfo] Keep the DWARF64 flag in the module metadata

Fri Feb 12 12:01:30 PST 2021

dblaikie accepted this revision.
dblaikie added a subscriber: aprantl.
dblaikie added a comment.
This revision is now accepted and ready to land.

@aprantl - mind having a look at this/signing off as well, if you're OK with it? Since it's a core metadata change, wouldn't mind some extra eyes on it.

================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:396
+  bool Dwarf64 =
+      (Asm->TM.Options.MCOptions.Dwarf64 || MMI->getModule()->isDwarf64()) &&
+      DwarfVersion >= 3 &&   // DWARF64 was introduced in DWARFv3.
----------------
Once this patch is accepted, it's probably worth going back and removing the MCOption? (I don't think we have MCOptions for other debug related module metadata, like the DWARF version?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96597/new/

https://reviews.llvm.org/D96597